---
name: code-review
description: Use when reviewing a pull request or diff. Looks for correctness, edge cases, performance, security and maintainability, and gives clear, prioritised feedback.
---

# Code review

Draft from the Game studio skills library by THE DREAMING JESTER. Adapt it to your game, team and engine.

## Goal

Catch problems before they reach players, and help the author improve the change.

## Before you start

- Read the description and the linked design or issue so you know what the change should do.
- Check that the automated checks have passed.

## Process

1. Understand the intent, then read the diff with it in mind.
2. Check correctness first: logic, edge cases, error handling, state, threading and timing.
3. Check game-specific risks: frame-rate dependence, save compatibility, network authority, memory and per-frame allocation.
4. Check security and data handling where players, accounts or networks are involved.
5. Check clarity: names, structure and comments where intent is not obvious.
6. Run or play the change when behaviour or feel matters.
7. Label feedback by priority: must fix, should fix, or optional suggestion. Explain why for each.

## Quality bar

- Blocking issues are clearly marked and explained.
- Feedback is about the code, specific and actionable.
- Approval means you would be comfortable shipping it.

## Output

Prioritised review comments and an explicit decision: approve, request changes or comment.

## Avoid

- Style debates that a formatter should settle.
- Approving changes you did not understand.